-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Improve browser history navigation #83792
[ML] Improve browser history navigation #83792
Conversation
Pinging @elastic/ml-ui (:ml) |
Pinging @elastic/apm-ui (Team:apm) |
...lugins/ml/public/application/components/controls/checkbox_showcharts/checkbox_showcharts.tsx
Outdated
Show resolved
Hide resolved
For a job using a Used cloudwatch and this config (need to create the job in the Advanced wizard):
|
As discussed, would be nice if only one click was required to return the Jobs list after opening the Single Metric Viewer for a job with a partition field. Currently two clicks are required (because the |
Shouldn't be the case anymore, could you please check with the latest changes @peteharverson |
Tested and LGTM 🎉 |
x-pack/plugins/security_solution/public/common/components/ml/links/create_explorer_link.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, LGTM pending the issue Pete found :) . Just added one question/suggestion.
x-pack/plugins/ml/public/application/explorer/hooks/use_selected_cells.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest edits and LGTM.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for security_solution
* [ML] replace history support * [ML] explorer url state * [ML] timeseriesexplorer url state * [ML] fix state keys for mlSelectSeverity and mlSelectInterval * [ML] fix useSelectedCells * [ML] update urls and tests in security app * [ML] fix TS * [ML] fix apm unit tests * [ML] fix typo * [ML] remove state sync * [ML] fix initial zoom set * [ML] fix initial zoom set * [ML]: update with useMlHref * [ML] fix TS issue
Summary
Fixes #73261
Part of #83033
Checklist