Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): skip docker build if docker binary is not available #84154

Merged
merged 1 commit into from
Nov 24, 2020
Merged

chore(NA): skip docker build if docker binary is not available #84154

merged 1 commit into from
Nov 24, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 23, 2020

That PR enable us to only run .ci/build_docker.sh if the docker binary is available.

@mistic mistic added chore Team:Operations Team label for Operations Team build v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 23, 2020
@mistic mistic requested a review from spalger November 23, 2020 20:27
@mistic mistic self-assigned this Nov 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

spalger
spalger approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit e559a61 into elastic:master Nov 24, 2020
mistic added a commit to mistic/kibana that referenced this pull request Nov 24, 2020
@mistic
chore(NA): skip docker build if docker binary is not available (elast…
b86e488 
…ic#84154)
@mistic mistic mentioned this pull request Nov 24, 2020
Merged
@mistic
Copy link
Member Author

mistic commented Nov 24, 2020 •
edited
Loading

7.x: b3abe47

mistic added a commit that referenced this pull request Nov 24, 2020
@mistic
chore(NA): skip docker build if docker binary is not available (#84154)…
b3abe47 
… (#84170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@mistic mistic

Labels
build chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistic @elasticmachine @kibanamachine @spalger