[Enterprise Search] Migrate shared Schema components #84381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These components were not changed, with the exception of lint fixes and TypeScript changes (adding types). The only exceptions are: 1. The `formatFieldName` in `SchemaAddFieldModal`. In `ent-search`, this was a shared util, but since it was not used anywhere else, I just added the method as a function in this component. 2. The `IFieldCoercionErrors` interface is only used here so I did not add it to the shared types file and instead jut added it to this component.
scottybollinger
added
Feature:Plugins
release_note:skip
Coverage was fine but wasn’t actually testing correctly
yakhinvadim
approved these changes
Nov 30, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Nov 30, 2020
* Migrate shared Schema components These components were not changed, with the exception of lint fixes and TypeScript changes (adding types). The only exceptions are: 1. The `formatFieldName` in `SchemaAddFieldModal`. In `ent-search`, this was a shared util, but since it was not used anywhere else, I just added the method as a function in this component. 2. The `IFieldCoercionErrors` interface is only used here so I did not add it to the shared types file and instead jut added it to this component. * Use EuiLinkTo instead of Link * Add unit tests * Better test for `hideName` Coverage was fine but wasn’t actually testing correctly * Add i18n * FIx test that didn’t pass eslint Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 30, 2020
* master: (25 commits) [Alerting] fixes buggy default message behaviour (elastic#84202) [Graph] Use new ES client and change license API (elastic#84398) [DOCS] Adds redirect to known plugins page (elastic#84001) Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376) Adding timestamps to created events so the sorting is stable (elastic#84515) [DOCS] Redirects for drilldown links (elastic#83846) [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805) [Enterprise Search] Migrate shared Schema components (elastic#84381) [Discover] Unskip date_nanos and shard links functional tests (elastic#82878) [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) ...
scottybollinger
added a commit
that referenced
this pull request
Nov 30, 2020
* Migrate shared Schema components These components were not changed, with the exception of lint fixes and TypeScript changes (adding types). The only exceptions are: 1. The `formatFieldName` in `SchemaAddFieldModal`. In `ent-search`, this was a shared util, but since it was not used anywhere else, I just added the method as a function in this component. 2. The `IFieldCoercionErrors` interface is only used here so I did not add it to the shared types file and instead jut added it to this component. * Use EuiLinkTo instead of Link * Add unit tests * Better test for `hideName` Coverage was fine but wasn’t actually testing correctly * Add i18n * FIx test that didn’t pass eslint Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate shared Schema components used by both App Search and Workplace Search.
Was unable to achieve 100% test coverage due to this line.
Checklist