Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new EQL icon to rule creation flow [Pending EUI update] #84934

Merged
merged 4 commits into from
Dec 10, 2020
Merged

Add new EQL icon to rule creation flow [Pending EUI update] #84934

merged 4 commits into from
Dec 10, 2020

Conversation

marrasherrier
Copy link
Contributor

@marrasherrier marrasherrier commented Dec 3, 2020 •
edited
Loading

Summary

This PR adds the new EQL icon to the rule creation flow.
Screen Shot 2020-12-09 at 1 12 49 PM

Checklist

For maintainers

@marrasherrier marrasherrier requested review from a team as code owners December 3, 2020 19:12
@marrasherrier marrasherrier changed the title Add new EQL icon to rule creation flow Add new EQL icon to rule creation flow [Pending EUI update] Dec 3, 2020
@rylnd
Copy link
Contributor

rylnd commented Dec 4, 2020

Looks like #84677 will bring the EUI icon into kibana. Until then, the build is failing due to the remaining reference to the old icon.

@spong
Copy link
Member

spong commented Dec 4, 2020

@elasticmachine merge upstream

@spong spong added Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 4, 2020
@spong
Copy link
Member

spong commented Dec 10, 2020

@elasticmachine merge upstream

spong
spong approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Grats on the PR @marrasherrier! 😀 🎉

Looks like you're getting hit by a flakey test, but hopefully this latest merge upstream will get you 🟢.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2117 2116 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.3MB 8.2MB -2.1KB

Distributable file count

id before after diff
default 46991 47750 +759

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peluja1012
peluja1012 approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Marra! Looks great!

@marrasherrier marrasherrier merged commit 6ef4764 into elastic:master Dec 10, 2020
@marrasherrier marrasherrier mentioned this pull request Dec 10, 2020
Merged
spong pushed a commit that referenced this pull request Dec 11, 2020
@marrasherrier @kibanamachine
Add new EQL icon to rule creation flow [Pending EUI update] (#84934) (#…
e3f2c37 
…85636)

* updating eql icon

* deleted import line

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@peluja1012 peluja1012 peluja1012 approved these changes

Assignees
No one assigned
Labels
Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marrasherrier @rylnd @spong @kibanamachine @peluja1012