[Monitoring] Fully control the in memory table pagination/sorting properties #85862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
release_note:fix
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
chrisronline
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Jan 4, 2021
…perties (elastic#85862) * Fully control the basic table pagination/sorting properties * Not necessary * Support index listing page Co-authored-by: Kibana Machine <[email protected]>
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Jan 4, 2021
…perties (elastic#85862) * Fully control the basic table pagination/sorting properties * Not necessary * Support index listing page Co-authored-by: Kibana Machine <[email protected]>
chrisronline
added a commit
that referenced
this pull request
Jan 4, 2021
…perties (#85862) (#87218) * Fully control the basic table pagination/sorting properties * Not necessary * Support index listing page Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
chrisronline
added a commit
that referenced
this pull request
Jan 4, 2021
…perties (#85862) (#87217) * Fully control the basic table pagination/sorting properties * Not necessary * Support index listing page Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 5, 2021
…perties (elastic#85862) * Fully control the basic table pagination/sorting properties * Not necessary * Support index listing page Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/monitoring/public/views/apm/instances/index.js
chrisronline
added a commit
that referenced
this pull request
Feb 9, 2021
…perties (#85862) (#90430) * Fully control the basic table pagination/sorting properties * Not necessary * Support index listing page Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/plugins/monitoring/public/views/apm/instances/index.js Co-authored-by: Kibana Machine <[email protected]>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #85318
Resolves #83175
In elastic/eui#4369, it seems that we need to fully control the pagination and sorting for in memory tables (which is the majority of our tables). This PR addresses that by updating the pagination/sorting properties on
onTableChangeand then ensuring the component is re-rendered.The following listing pages are affected:
The ES nodes and Logstash pipelines use server-side pagination/sorting and are not affected by this issue.