Flag scripted fields as searchable and aggregatable #8588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Oct 7, 2016
--------- **Commit 1:** Flag scripted fields as searchable and aggregatable * Original sha: 701ceed * Authored by Matthew Bargar <[email protected]> on 2016-10-07T19:15:59Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 7, 2016
--------- **Commit 1:** Flag scripted fields as searchable and aggregatable * Original sha: 701ceed * Authored by Matthew Bargar <[email protected]> on 2016-10-07T19:15:59Z
This was referenced Oct 7, 2016
epixa
added a commit
that referenced
this pull request
Oct 7, 2016
[backport] PR #8588 to 5.x - Flag scripted fields as searchable and aggregatable
epixa
added a commit
that referenced
this pull request
Oct 7, 2016
[backport] PR #8588 to 5.0 - Flag scripted fields as searchable and aggregatable
|
Does this mean that field_stats is not returning searchable/aggregatable for scripted fields? |
|
Scripted fields don't exist in elasticsearch indices, they're simulated by Kibana |
|
Duh. Of course this change only affects the index patterns and in no way touches script fields in ES queries. I was just testing you. ... |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Flag scripted fields as searchable and aggregatable * Original sha: fedfe5004392599387b1212734f819be5368d52b [formerly 701ceed] * Authored by Matthew Bargar <[email protected]> on 2016-10-07T19:15:59Z Former-commit-id: e31430b
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8588 to 5.x - Flag scripted fields as searchable and aggregatable Former-commit-id: 99e38a7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8585
Scripted fields were being filtered out of the available field list in the viz editor because of the new reliance on the searchable and aggregatable flags #8421
This PR ensures that all scripted fields get flagged as searchable and aggregatable.