Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] fix timeline tabs + layout #86581

Merged
merged 4 commits into from
Dec 19, 2020
Merged

[Security Solutions] fix timeline tabs + layout #86581

merged 4 commits into from
Dec 19, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Dec 18, 2020 •
edited
Loading

Summary

  • Made a mistake using activeTab to define key, this create some really bad performance on the timeline
  • Fix an issue where notes and row-render can be focus by a mouse
  • Fix a performance issue where hovering over tooltip cause an en expensive layout calculation on the browser

Checklist

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Dec 18, 2020
@XavierM XavierM requested review from a team as code owners December 18, 2020 22:58
@XavierM XavierM changed the title [Security Solutions] fix timeline tabs + fix screenreader [Security Solutions] fix timeline tabs + layout Dec 18, 2020
andrew-goldstein
andrew-goldstein approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes @XavierM! 🙏
Tested locally with the suggested changes
LGTM 🚀

@XavierM XavierM removed the request for review from a team December 19, 2020 12:18
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +4.7KB

Distributable file count

id before after diff
default 47303 48063 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 9fce3b2 into elastic:master Dec 19, 2020
@XavierM XavierM mentioned this pull request Dec 19, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Dec 19, 2020
@XavierM
[Security Solutions] fix timeline tabs + layout (elastic#86581)
3800acb 
* fix timeline tabs + fix screenreader

* review

* fix jest tests
@XavierM XavierM mentioned this pull request Dec 19, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Dec 19, 2020
@XavierM
[Security Solutions] fix timeline tabs + layout (elastic#86581)
16a543a 
* fix timeline tabs + fix screenreader

* review

* fix jest tests
XavierM added a commit that referenced this pull request Dec 20, 2020
@XavierM
[Security Solutions] fix timeline tabs + layout (#86581) (#86596)
5249807 
* fix timeline tabs + fix screenreader

* review

* fix jest tests
XavierM added a commit that referenced this pull request Dec 20, 2020
@XavierM
[Security Solutions] fix timeline tabs + layout (#86581) (#86595)
c539510 
* fix timeline tabs + fix screenreader

* review

* fix jest tests
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 21, 2020
@gmmorris
Merge branch 'master' into alerts/remove-generics-defaults-redux
561ebb1 
* master: (48 commits)
  Fix request with disabled aggregation (elastic#85696)
  [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918)
  Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236)
  Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593)
  [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370)
  [Security Solutions] fix timeline tabs + layout (elastic#86581)
  Upgrade to hapi version 20 (elastic#85406)
  App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791)
  Rename chartLibrary setting to legacyChartsLibrary (elastic#86529)
  [CI] TeamCity updates (elastic#85843)
  [Maps] Use Json for mvt-tests (elastic#86492)
  [Rollup Jobs] Added autofocus to cron editor (elastic#86324)
  [Monitoring][Alerting] CCR read exceptions alert (elastic#85908)
  [CI] Bump memory for main CI workers (elastic#86541)
  Explicitly set Elasticsearch heap size during CI and local development (elastic#86513)
  [App Search] Updates to results on the documents view (elastic#86181)
  [Discover] Change default sort handling  (elastic#85561)
  [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508)
  [App Search] Sample Engines should have access to the Crawler (elastic#86502)
  Fixed duplication of create new modal (elastic#86489)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XavierM @kibanamachine @andrew-goldstein