-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [Detections] Update search after to use one single date range filter #86921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhurley14
force-pushed
the
replace-should-date
branch
from
January 5, 2021 22:50
b70b098
to
477682b
Compare
dhurley14
force-pushed
the
replace-should-date
branch
from
January 5, 2021 23:16
93fa98a
to
e015a07
Compare
dhurley14
added
release_note:fix
review
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Detections and Resp
Security Detection Response Team
v7.11.0
v7.12.0
v8.0.0
labels
Jan 5, 2021
@elasticmachine merge upstream |
spong
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once green -- thanks @dhurley14! 🙂
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
spong
pushed a commit
to spong/kibana
that referenced
this pull request
Jan 6, 2021
…e date range filter (elastic#86921) ## Summary Ref: elastic#86874 replaces `should` with a single lower bounded and upper bounded date range filter. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
spong
pushed a commit
to spong/kibana
that referenced
this pull request
Jan 6, 2021
…e date range filter (elastic#86921) ## Summary Ref: elastic#86874 replaces `should` with a single lower bounded and upper bounded date range filter. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
peluja1012
pushed a commit
that referenced
this pull request
Jan 6, 2021
…e date range filter (#86921) (#87428) ## Summary Ref: #86874 replaces `should` with a single lower bounded and upper bounded date range filter. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Devin W. Hurley <[email protected]>
peluja1012
pushed a commit
that referenced
this pull request
Jan 6, 2021
…e date range filter (#86921) (#87429) ## Summary Ref: #86874 replaces `should` with a single lower bounded and upper bounded date range filter. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Devin W. Hurley <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:fix
review
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v7.11.0
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref: #86874
replaces
should
with a single lower bounded and upper bounded date range filter.Checklist
Delete any items that are not applicable to this PR.
For maintainers