Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution] [Detections] Multiple timestamp fields (#86368) #86926

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

dhurley14
Copy link
Contributor

Backports the following commits to 7.x:

…6368)

* query timestamp override and default @timestamp field, adds functional test for this

* fix logic for when to filter out timestamp override documents

* update the total hits field of the search result if we find hits within the secondary search. Without updating the total hits field, we could be finding events but not indexing them based on the bulk create logic

* update integration test, updates logic for performing second search and excluding documents with timestamp override field

* cleanup comments, remove commented out console logs, fix logic to break out of loop during secondary search after

* default param to 'succeeded'

* remove commented out code

* always perform a secondary search when timestamp override field is present

* perf improvement and fix bug where sortIds were being mixed between search after calls

* set sortIds to undefined when not present on search result

* exit loop and prevent extraneous searches from occurring if we exhaust sort ids
@dhurley14 dhurley14 force-pushed the backport/7.x/pr-86368 branch from aa3aec2 to f6a8f49 Compare January 4, 2021 21:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -26.9KB

Distributable file count

id before after diff
default 47589 48352 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.5KB 162.6KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dhurley14 dhurley14 merged commit 3e50b5f into elastic:7.x Jan 5, 2021
@dhurley14 dhurley14 deleted the backport/7.x/pr-86368 branch January 5, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants