Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix pop up message #86973

Merged
merged 5 commits into from
Jan 4, 2021
Merged

[Security Solution] Fix pop up message #86973

merged 5 commits into from
Jan 4, 2021

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Dec 28, 2020 •
edited
Loading

Summary

issue description and steps to reproduce:
#85011

After fixing:
Screenshot 2020-12-29 at 02 55 53
Screenshot 2020-12-29 at 02 57 43

In regarding to testing, I'd like to add some Cypress tests to #86653 once this PR is merged.

@angorayc angorayc added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 28, 2020
@angorayc angorayc requested review from a team as code owners December 28, 2020 19:21
@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@angorayc
Copy link
Contributor Author

angorayc commented Jan 4, 2021

@elasticmachine merge upstream

patrykkopycinski
patrykkopycinski approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +636.0B

Distributable file count

id before after diff
default 47264 48024 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 9ed0bbd into elastic:master Jan 4, 2021
@angorayc angorayc mentioned this pull request Jan 4, 2021
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Jan 4, 2021
@angorayc @kibanamachine
[Security Solution] Fix pop up message (elastic#86973)
328d510 
* fix wording

* update wording

* remove logic in translation

Co-authored-by: Kibana Machine <[email protected]>
@angorayc angorayc mentioned this pull request Jan 4, 2021
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Jan 4, 2021
@angorayc @kibanamachine
[Security Solution] Fix pop up message (elastic#86973)
8c76964 
* fix wording

* update wording

* remove logic in translation

Co-authored-by: Kibana Machine <[email protected]>
angorayc added a commit that referenced this pull request Jan 4, 2021
@angorayc @kibanamachine
[Security Solution] Fix pop up message (#86973) (#87205)
d6c885d 
* fix wording

* update wording

* remove logic in translation

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
patrykkopycinski pushed a commit that referenced this pull request Jan 5, 2021
@angorayc
[Security Solution] Fix pop up message (#86973) (#87204)
17ad2c5
@oatkiller oatkiller added the Feature:Timeline Security Solution Timeline feature label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees
No one assigned
Labels
Feature:Timeline Security Solution Timeline feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angorayc @kibanamachine @patrykkopycinski @oatkiller