Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix earliest and latest texts for date fields #87482

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jan 6, 2021

Summary

This PR fixes wrong texts in the date row for the data visualizer grid.

Before
image

After
Screen Shot 2021-01-06 at 07 48 42

Checklist

Delete any items that are not applicable to this PR.

@qn895 qn895 added bug Fixes for quality problems that affect the customer experience :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:File and Index Data Viz ML file and index data visualizer v7.11.0 v7.12.0 v7.11.1 labels Jan 6, 2021
@qn895 qn895 requested review from peteharverson and lcawl January 6, 2021 13:45
@qn895 qn895 self-assigned this Jan 6, 2021
@qn895 qn895 requested a review from a team as a code owner January 6, 2021 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member Author

qn895 commented Jan 6, 2021

@elasticmachine merge upstream

@qn895
Copy link
Member Author

qn895 commented Jan 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 7.0MB 7.0MB +10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@qn895 qn895 merged commit db022a3 into elastic:master Jan 8, 2021
@qn895 qn895 deleted the ml-fix-data-viz-date-texts branch January 8, 2021 19:23
qn895 added a commit to qn895/kibana that referenced this pull request Jan 8, 2021
qn895 added a commit to qn895/kibana that referenced this pull request Jan 8, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 11, 2021
* master:
  [APM] Define placement “Right” to offset tooltip (elastic#87729)
  Fix UI glitch on SOM delete confirmation modal (elastic#87623)
  Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (elastic#86988)
  [Timelion] Fix tests flakiness on suggestion click (elastic#87273)
  [Uptime] Fix/details page tabs (elastic#86296)
  [ML] Fix earliest and latest texts for date fields (elastic#87482)
  chore(NA): move grokdebugger plugin test fixtures out of __tests__ folder (elastic#87765)
  [Security Solution] Refactor Cypress scenarios to use internal contex… (elastic#86609)
  [Security Solution] Unskip cypress tests (elastic#86653)
qn895 added a commit that referenced this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:File and Index Data Viz ML file and index data visualizer :ml release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants