Prevent kibana crashing when multiple processes start APM telemetry task #87645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
bug
dgieselaar
approved these changes
Jan 7, 2021
|
Pinging @elastic/apm-ui (Team:apm) |
Good question. @elastic/kibana-alerting-services @gmmorris |
|
@elasticmachine merge upstream |
Based on this PR, the runNow API returns a promise that identifies if the task completed successfully or not (including error messages, etc). In the scenario the task is currently running (possibly by another Kibana instance), the API will throw since it can't capture the outcome. (@gmmorris keep me honest). |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Jan 11, 2021
…ask in parallel (elastic#87645) Co-authored-by: Kibana Machine <[email protected]>
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Jan 11, 2021
…ask in parallel (elastic#87645) Co-authored-by: Kibana Machine <[email protected]>
rudolf
added a commit
that referenced
this pull request
Jan 12, 2021
…ask in parallel (#87645) (#87923) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
rudolf
added a commit
that referenced
this pull request
Jan 12, 2021
…ask in parallel (#87645) (#87924) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When multiple Kibana process are started in parallel they all attempt to start the
apm-telemetry-tasktask in parallel. Because thetaskManagerStart.runNowpromise wasn't awaited it would sometimes cause an unhandled promise rejection when another process already started this task and crash Kibana.Release notes
Fixed a bug that would sometimes cause the Kibana process to crash with
Error: Failed to run task "apm-telemetry-task" as it is currently running.Checklist
Delete any items that are not applicable to this PR.
For maintainers