Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] add "traces" type to data stream list #87985

Merged
merged 2 commits into from
Jan 14, 2021
Merged

[Fleet] add "traces" type to data stream list #87985

merged 2 commits into from
Jan 14, 2021

Conversation

axw
Copy link
Member

@axw axw commented Jan 12, 2021 •
edited
Loading

Summary

Update the index pattern used for populating the list of data streams to include traces-*-*.

Without this, traces data streams created by APM will not show up in the Data streams UI (see elastic/apm-server#4473 (comment))

Checklist

Delete any items that are not applicable to this PR.

- [ ] Unit or functional tests were updated or added to match the most common scenarios (couldn't find relevant tests, please direct me if there are some)

For maintainers

@axw
[Fleet] add "traces" type to data stream list
4f5bad3 
Update the index pattern uysed for populating
the list of data streams to include traces-*-*.
@axw axw added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Jan 12, 2021
@axw axw requested a review from a team January 12, 2021 09:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

jen-huang
jen-huang reviewed Jan 12, 2021
View reviewed changes
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me but I'd like @ruflin to look at this too: does this make sense from an indexing strategy perspective?

@jen-huang jen-huang requested a review from ruflin January 12, 2021 17:24
ruflin
ruflin approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axw
Copy link
Member Author

axw commented Jan 13, 2021

@elasticmachine merge upstream

@jalvz jalvz mentioned this pull request Jan 13, 2021
Closed
15 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@axw axw merged commit 0eb5c7b into elastic:master Jan 14, 2021
@axw axw deleted the fleet-datastreams-list-traces branch January 14, 2021 01:29
@axw axw removed the v7.11.0 label Jan 14, 2021
@axw axw mentioned this pull request Jan 14, 2021
Merged
axw added a commit that referenced this pull request Jan 14, 2021
@axw @kibanamachine
[Fleet] add "traces" type to data stream list (#87985) (#88300)
022c132 
Update the index pattern uysed for populating
the list of data streams to include traces-*-*.

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jen-huang jen-huang jen-huang left review comments

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@axw @elasticmachine @kibanamachine @ruflin @jen-huang