removing kibana-core-ui from codeowners #88111
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -98,18 +98,6 @@ | |
| #CC# /x-pack/legacy/plugins/canvas/ @elastic/kibana-presentation | ||
| #CC# /x-pack/plugins/dashboard_mode @elastic/kibana-presentation | ||
|
|
||
|
|
||
| # Observability UIs | ||
| /x-pack/plugins/infra/ @elastic/logs-metrics-ui | ||
|
|
@@ -138,10 +126,6 @@ | |
| /x-pack/test/functional/apps/maps/ @elastic/kibana-gis | ||
| /x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis | ||
| /x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis | ||
| #CC# /src/plugins/maps_legacy/ @elastic/kibana-gis | ||
| #CC# /src/plugins/maps_oss/ @elastic/kibana-gis | ||
| #CC# /x-pack/plugins/file_upload @elastic/kibana-gis | ||
|
|
@@ -200,6 +184,11 @@ | |
| /src/plugins/status_page/ @elastic/kibana-core | ||
| /src/plugins/saved_objects_management/ @elastic/kibana-core | ||
| /src/dev/run_check_published_api_changes.ts @elastic/kibana-core | ||
| /src/plugins/home/public @elastic/kibana-core | ||
| /src/plugins/home/server/*.ts @elastic/kibana-core | ||
| /src/plugins/home/server/services/ @elastic/kibana-core | ||
| /src/plugins/kibana_overview/ @elastic/kibana-core | ||
| /x-pack/plugins/global_search_bar/ @elastic/kibana-core | ||
| #CC# /src/core/server/csp/ @elastic/kibana-core | ||
| #CC# /src/legacy/server/config/ @elastic/kibana-core | ||
| #CC# /src/legacy/server/http/ @elastic/kibana-core | ||
|
|
@@ -210,6 +199,11 @@ | |
| #CC# /x-pack/plugins/cloud/ @elastic/kibana-core | ||
| #CC# /x-pack/plugins/features/ @elastic/kibana-core | ||
| #CC# /x-pack/plugins/global_search/ @elastic/kibana-core | ||
| #CC# /src/plugins/newsfeed @elastic/kibana-core | ||
| #CC# /src/plugins/home/public @elastic/kibana-core | ||
| #CC# /src/plugins/home/server/services/ @elastic/kibana-core | ||
| #CC# /src/plugins/home/ @elastic/kibana-core | ||
|
Comment on lines
+203
to
+205
There was a problem hiding this comment. Same as above, I thought Kibana App owned this now, but I could be wrong? There was a problem hiding this comment. @timroes what do you think? There was a problem hiding this comment. Nope we def gave away home and sample data to Core UI that time, not sure where it went from there, but Kibana App does not own that. My understanding from the Team organization wiki page is that Design > Kibana Design owns that currently? If that's not true, most likely we should also fix the wiki page :-) There was a problem hiding this comment. For both of these, the logic that originally moved them to Core UI still applies, I'd rather we left them on the Core team's responsibilities and created a hiring plan around it if there isn't bandwidth to cover them. There was a problem hiding this comment. It's uncomfortable to be pushing more onto either team (Core or App). However, the Core UI team is simply no more and the Kibana Design team has a very different set of objectives with even less engineering bandwith (almost none beyond the accessibility commitment). As an aside, the main home page is also likely to evolve into something more complex based upon the Getting Started project. As the ingest management capabilities evolve, there is quite likely to more dynamic, user/space/role oriented content regarding managing data. It's a tough spot, and we're here to support things that arise where we can. Hopefully, the load from these two areas (home and overview page) is very quiet in the meantime. There was a problem hiding this comment. I must have gotten this confused with the ownership transition of the Management app going to the Kibana App team. I'm fine with Core team owning this plugin. AFAIK there aren't any expected large changes to this UI other than possibly removing the feature catalog (since we now have navigational search). There was a problem hiding this comment. @ryankeairns - not a problem at all. |
||
| #CC# /x-pack/plugins/global_search_providers/ @elastic/kibana-core | ||
|
|
||
| # Kibana Telemetry | ||
| /packages/kbn-analytics/ @elastic/kibana-core | ||
|
|
@@ -236,7 +230,6 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib | |
| # Security | ||
| /src/core/server/csp/ @elastic/kibana-security @elastic/kibana-core | ||
| /src/plugins/security_oss/ @elastic/kibana-security | ||
| /test/security_functional/ @elastic/kibana-security | ||
| /x-pack/plugins/spaces/ @elastic/kibana-security | ||
| /x-pack/plugins/encrypted_saved_objects/ @elastic/kibana-security | ||
|
|
@@ -263,7 +256,7 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib | |
| /x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/ @elastic/kibana-alerting-services | ||
| /docs/user/alerting/ @elastic/kibana-alerting-services | ||
| /docs/management/alerting/ @elastic/kibana-alerting-services | ||
| #CC# /x-pack/plugins/stack_alerts @elastic/kibana-alerting-services | ||
|
|
||
| # Enterprise Search | ||
| # Shared | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought Kibana App owned this now, but I could be wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timroes what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here as below, we did never create or owned this, as it was created as part of the getting started experience, and from my understanding (and the wiki page) should be Design > Kibana Design. But I would say since this is the "analytics home" page not the general one, we could def argue if this should be owned by someone within the analytics area, in which case I feel/fear it will be Kibana App :D cc @timductive