[APM] Only display relevant sections for rum agent in service overview #88410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogupte
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
smith
approved these changes
Jan 14, 2021
x-pack/plugins/apm/public/components/app/service_overview/index.tsx
Outdated
Show resolved
Hide resolved
|
Would it be possible to change the "Take me there" link to account for the selected service, so when the UX app opens it has the previously visited RUM service selected already? Right now, UX app just picks the firstmost app to display. 🤞 it's a simple link fix... |
sorenlouv
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Agree with @formgeist point about linking to the service (if easy to implement).
Apart from that lgtm.
Btw. can you create a follow-up issue for showing Dependencies table again when made possible by the RUM agent? (hopefully 7.12)
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jan 15, 2021
elastic#88410) * [APM] Only display relevent sections for rum agent in service overview (elastic#85546) * call `isRumAgentName` once * User experience callout links to the selected service
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jan 15, 2021
elastic#88410) * [APM] Only display relevent sections for rum agent in service overview (elastic#85546) * call `isRumAgentName` once * User experience callout links to the selected service
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 18, 2021
* master: (33 commits) [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311) [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420) Fix log msg (elastic#88370) [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600) removing kibana-core-ui from codeowners (elastic#88111) [Alerting] Migrate Event Log plugin to TS project references (elastic#81557) [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413) Porting fixes 1 (elastic#88477) [APM] Explicitly set environment for cross-service links (elastic#87481) chore(NA): remove mocha junit ci integrations (elastic#88129) [APM] Only display relevant sections for rum agent in service overview (elastic#88410) [Enterprise Search] Automatically mock shared logic files (elastic#88494) [APM] Disable Create custom link button on Transaction details page for read-only users [Docs] clean-up vega map reference documenation (elastic#88487) [Security Solution] Fix Timeline event details layout (elastic#88377) Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914) [Monitoring] Change cloud messaging on no data page (elastic#88375) [Uptime] clear ping state when PingList component in unmounted (elastic#88321) [APM] Consistent terminology for latency and throughput (elastic#88452) fix copy (elastic#88481) ...
ogupte
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #85546. Hides instances and dependencies tables form service overview. Also displays the callout which links to the User Experience app.