[Alerting] Configurable number of hits for ES query alert #90089
Conversation
…ing/search-alert-configurable-hits
…ing/search-alert-configurable-hits
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
| }) | ||
| ); | ||
| } | ||
| if ((size && size < 0) || size > 10000) { |
There was a problem hiding this comment.
I tried putting the ES_QUERY_MAX_HITS_PER_EXECUTION const into common and using it inside this validation function but I got an optimizer error related to joi.
There was a problem hiding this comment.
I think this is caused by a config.ts file that shouldn't be in common (https://github.com/elastic/kibana/blob/master/x-pack/plugins/stack_alerts/common/config.ts). If that file gets moved to the server-side, it could work.
…ing/search-alert-configurable-hits
|
@elasticmachine merge upstream |
| }) | ||
| ); | ||
| } | ||
| if ((size && size < 0) || size > 10000) { |
There was a problem hiding this comment.
I think this is caused by a config.ts file that shouldn't be in common (https://github.com/elastic/kibana/blob/master/x-pack/plugins/stack_alerts/common/config.ts). If that file gets moved to the server-side, it could work.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
) * Adding size parameter to ES query alert * Can't use const inside validation * Updating docs * Fixing functional test * License Co-authored-by: Kibana Machine <[email protected]>
…90830) * Adding size parameter to ES query alert * Can't use const inside validation * Updating docs * Fixing functional test * License Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Resolves #89561
Summary
Added
sizeas a parameter of the ES query alert, with a default of 100Checklist
Delete any items that are not applicable to this PR.