-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vislib Point Series updates #9044
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ba74498
renaming x-axis to axis
ppisljar f27f8a1
fixing selenium tests by increasing barHeightTolerance
ppisljar 3d6267e
fixing axis alignment (1px off)
ppisljar 619a495
fixing layout elements min-height to 0
ppisljar be16b14
point radius should be calculated per chart
ppisljar 188131b
adding clip path to circles
ppisljar 231a58a
seting min height 0 on axis
ppisljar c41e672
adding background class
ppisljar ed1b330
fixing selenium tests
ppisljar 9bd80be
update visualize legend to correctly check if it should show
ppisljar 02a22d0
fixing based on CJs comments
ppisljar 9d79d79
improving stacking of negative values
ppisljar 628408d
updating class name to better match element
ppisljar 682ab0b
fixing charts with mixed (negative/positive) values
ppisljar 69a53ea
fixing test (stacking happens for grouped charts as well to handle ne…
ppisljar 9e8d71f
fixing based on CJs last comments
ppisljar f36b6fc
fixing unstable selenium test
ppisljar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Vislib general overview | ||
|
||
`vis.js` constructor accepts vis parameters and render method accepts data. it exposes event emitter interface so we can listen to certain events like 'renderComplete'. | ||
|
||
`vis.render` will create 'lib/vis_config' to handle configuration (applying defaults etc) and then create 'lib/handler' which will take the work over. | ||
|
||
`vis/handler` will init all parts of the chart (based on visualization type) and call render method on each of the building blocks. | ||
|
||
## Visualizations | ||
|
||
Each base vis type (`lib/types`) can have a different layout defined (`lib/layout`) and different building blocks (pie charts dont have axes for example) | ||
|
||
All base visualizations extend from `visualizations/_chart` | ||
|
||
### Pie chart | ||
|
||
### Map | ||
|
||
### Point series chart | ||
|
||
`visualizations/point_series` takes care of drawing the point series chart (no axes or titles, just the chart itself). It creates all the series defined and calls render method on them. | ||
|
||
currently there are 3 series types available (line, area, bars), they all extend from `vislualizations/point_series/_point_series`. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this!