[Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness #90543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…20 seconds to see the container. Also changed the data test subject as there was another grokDebugger test subject just in case there was a clash.
cuff-links
added
Feature:Dev Tools
test_ui_functional
test_xpack_functional
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
cuff-links
added
the
release_note:skip
added 2 commits
February 5, 2021 23:11
… not in the flaky test runner.
|
@jloleysens Once you review, I will remove the |
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Happy with these changes @cuff-links ! How many successful non-flaky CI runs do we need of the unskipped suite of tests to be confident the flakiness is gone.
Just asking to better understand how this is determined :)
added 2 commits
February 8, 2021 19:37
…y test being skipped.
…s/kibana into Fixed_Grok_Debugger_Flaky_Test
@jloleysens Great question. From what I have been told, 50 seems to be the most consistent number that I have heard. This could also be applied to new tests as well. |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Feb 9, 2021
…xist to fix test flakiness (elastic#90543) * Changed the retry to a wait for condition which will keep trying for 20 seconds to see the container. Also changed the data test subject as there was another grokDebugger test subject just in case there was a clash. * Added .only to be able to run the test repeatedly because group 13 is not in the flaky test runner. * Added to group 11 because 13 is not in flaky test runner. Will revert after passing. * Reverted change back to group 13 and removed the comment for the flaky test being skipped. Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 9, 2021
…timeline-and-rollover-info * 'master' of github.com:elastic/kibana: (47 commits) [Fleet] Use TS project references (elastic#87574) before/beforeEach clean up (elastic#90663) [Vega] user should be able to set a specific tilemap service using the mapStyle property (elastic#88440) [Security Solution][Case] ServiceNow SIR Connector (elastic#88655) [Search Sessions] Enable extend from management (elastic#90558) [ILM] Delete phase redesign (rework) (elastic#90291) [APM-UI][E2E] use withGithubStatus step (elastic#90651) Add folding in kb-monaco and update some viewers (elastic#90152) [Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness (elastic#90543) Strongly typed EUI theme for styled-components (elastic#90106) Fix vega renovate label (elastic#90591) [Uptime] Migrate to TypeScript project references (elastic#90510) [Monitoring] Migrate data source for legacy alerts to monitoring data directly (elastic#87377) [Upgrade Assistant] Add A11y Tests (elastic#90265) [Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (elastic#89612) [dev-utils/ship-ci-stats] fail when CI stats is down (elastic#90678) chore(NA): remove write permissions on Bazel remote cache for PRs (elastic#90652) chore(NA): move bazel workspace status from bash script into nodejs executable (elastic#90560) Use default ES distribution for functional tests (elastic#88737) [Alerts] Jira: Disallow labels with spaces (elastic#90548) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.ts
cuff-links
pushed a commit
that referenced
this pull request
Feb 9, 2021
…xist to fix test flakiness (#90543) (#90729) * Changed the retry to a wait for condition which will keep trying for 20 seconds to see the container. Also changed the data test subject as there was another grokDebugger test subject just in case there was a clash. * Added .only to be able to run the test repeatedly because group 13 is not in the flaky test runner. * Added to group 11 because 13 is not in flaky test runner. Will revert after passing. * Reverted change back to group 13 and removed the comment for the flaky test being skipped. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84440
Summary
This test is to fix one of the tests from intermittent failures.
Changes made
retry.trycall toretry.waitForto explicitly wait 20 seconds for the grok debugger container to show up.grokDebuggertogrokDebuggerContainerbecause there is another element with the data test subjectgrokdebuggerand though there is a difference in the capitalization of the D, there could be issues with ambiguity when it comes to WebDriver.