-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime-UX] Added nav search keywords for uptime and user experience app #90616
Conversation
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:apm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one question on the code review.
'Javascript', | ||
'APM', | ||
'Mobile', | ||
'digital', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Digital" seems a little too general to me. Is there some UX-specific context to the term that I am missing?
cc @drewpost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generality was certainly what I was going for with this. With digital tied to so many things: digital performance, digital experience, digital transformation, I wanted to try and be general at the top of the funnel, so to speak, for discoverability reasons. cc @justinkambic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
'outside in', | ||
'reachability', | ||
'reachable', | ||
'digital', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment regarding digital
as the one I had in the UX keywords.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above:
Generality was certainly what I was going for with this. With digital tied to so many things: digital performance, digital experience, digital transformation, I wanted to try and be general at the top of the funnel, so to speak, for discoverability reasons. cc @justinkambic
'End User Monitoring', | ||
'UX', | ||
'Javascript', | ||
'APM', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is @elastic/apm-ui ok with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💚 Build SucceededMetrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any further concerns. LGTM!
Sorry @justinkambic. Not intentional - just fat fingers |
@sqren I was clearing GH notifications and came to this comment without any context. Initial reaction was "oh my.. how long has Søren been waiting for this review?" 🤣 |
Not very long it turns out :D |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Backport result
|
…app (#90616) (#91268) Co-authored-by: Shahzad <[email protected]>
Summary
Fixes: elastic/uptime#256
Added nav search keywords for uptime and user experience app
User can search for uptime using following keywords
and these deep links are also added
User can search for UX app using following keywords
Screenshots: