Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove xregexp package #91369

Merged
merged 4 commits into from
Feb 17, 2021
Merged

remove xregexp package #91369

merged 4 commits into from
Feb 17, 2021

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Feb 15, 2021

I've removed xregexp package by replacing it with native regexp and added tests to the affacted function. The package is almost 1mb in size.

related: #88678

@Bamieh Bamieh added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 15, 2021
@Bamieh Bamieh requested a review from tsullivan February 15, 2021 09:55
@Bamieh
Copy link
Member Author

Bamieh commented Feb 16, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bamieh Bamieh merged commit 832c639 into elastic:master Feb 17, 2021
@Bamieh Bamieh deleted the optimize/remove_xregexp branch February 17, 2021 15:10
Bamieh added a commit that referenced this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants