Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some package.json cleanup #92136

Merged
merged 3 commits into from
Feb 23, 2021
Merged

Some package.json cleanup #92136

merged 3 commits into from
Feb 23, 2021

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Feb 22, 2021 •
edited
Loading

Summary

Part of #88678

  • move @storybook/addons from dependency to devDependencies.
  • move cheerio from dependency to devDependencies.
  • get rid of react-portal since it is not used anywhere.
  • get rid of vscode-languageserver since it is not used anywhere.

@pgayvallet
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review February 22, 2021 16:40
@pgayvallet pgayvallet requested review from Bamieh and a team February 22, 2021 16:40
@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Feb 22, 2021
afharo
afharo approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TIL: Tracking back the usage of vscode-languageserver, I noticed it was used in x-pack/plugins/code. And some unuseful left-overs still exist in master: https://github.com/elastic/kibana/tree/master/x-pack/plugins/code 🤷

@pgayvallet pgayvallet merged commit 8988bdf into elastic:master Feb 23, 2021
This was referenced Feb 23, 2021
Merged
Open
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Feb 23, 2021
@pgayvallet
Some package.json cleanup (elastic#92136)
4a78526 
* some package.json cleanup

* update lockfile
pgayvallet added a commit that referenced this pull request Feb 23, 2021
@pgayvallet
Some package.json cleanup (#92136) (#92350)
501a018 
* some package.json cleanup

* update lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@Bamieh Bamieh Awaiting requested review from Bamieh

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgayvallet @kibanamachine @afharo