Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pattern management - fix refresh of index pattern list after delete #92619

Merged

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Feb 24, 2021

Summary

Index pattern management index pattern list was failing to load after deleting index pattern, leaving a blank screen. This ensures the list renders after deleting an index pattern. Bug introduced by #91839

Closes: #96024

Checklist

Delete any items that are not applicable to this PR.

@mattkime mattkime changed the title refresh id and title list Index pattern management - fix refresh of index pattern list after delete Feb 24, 2021
@mattkime
Copy link
Contributor Author

mattkime commented Apr 2, 2021

@elasticmachine merge upstream

@mattkime mattkime added v8.0.0 v7.13.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages bug Fixes for quality problems that affect the customer experience Team:AppServices release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 2, 2021
@mattkime mattkime marked this pull request as ready for review April 2, 2021 02:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@mattkime mattkime requested a review from Dosant April 2, 2021 02:32
@mattkime
Copy link
Contributor Author

mattkime commented Apr 6, 2021

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

mattkime commented Apr 7, 2021

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

mattkime commented Apr 8, 2021

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

mattkime commented Apr 9, 2021

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexPatternManagement 552.8KB 552.8KB +2.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit 2ab94f0 into elastic:master Apr 12, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 12, 2021
…lete (elastic#92619)

* refresh id and title list

* add functional test

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 12, 2021
…lete (#92619) (#96789)

* refresh id and title list

* add functional test

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Matthew Kime <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting an index pattern , breaks index pattern management ui
5 participants