[ML] Fixes positions of calendar arrow buttons in start datafeed modal #92625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Feb 25, 2021
elastic#92625) * [ML] Fixes positions of calendar arrow buttons in start datafeed modal * [ML] Move height styling to parent container. Co-authored-by: Kibana Machine <[email protected]>
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Feb 25, 2021
elastic#92625) * [ML] Fixes positions of calendar arrow buttons in start datafeed modal * [ML] Move height styling to parent container. Co-authored-by: Kibana Machine <[email protected]>
peteharverson
added a commit
that referenced
this pull request
Feb 25, 2021
#92625) (#92772) * [ML] Fixes positions of calendar arrow buttons in start datafeed modal * [ML] Move height styling to parent container. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
peteharverson
added a commit
that referenced
this pull request
Feb 25, 2021
#92625) (#92771) * [ML] Fixes positions of calendar arrow buttons in start datafeed modal * [ML] Move height styling to parent container. Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
* master: (38 commits) Fixes Cypress flake by adding pipe, click, and should (elastic#92762) [Discover] Fix filtering selected sidebar fields (elastic#91828) [ML] Fixes positions of calendar arrow buttons in start datafeed modal (elastic#92625) [dev/build_ts_refs] check that commit in outDirs matches mergeBase (elastic#92513) add dep on `@kbn/config` so it is built first [Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn (elastic#90481) [Lens] Fix Workspace hidden when using Safari (elastic#92616) [Lens] Fixes vertical alignment validation messages (elastic#91878) forbid x-elastic-product-origin header in elasticsearch configuration (elastic#92359) [Security Solution][Detections] Set default indicator path to reduce friction with new filebeat modules (elastic#92081) [ILM][Accessibility] Added A11y test for ILM new policy form. (elastic#92570) [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (elastic#90634) Automatically generated Api documentation (elastic#86232) Increase index pattern select limit to 1000 (elastic#92093) [core.logging] Add RewriteAppender for filtering LogMeta. (elastic#91492) [Security Solution][Detection Rules] Update prebuilt rule threats to match schema (elastic#92281) [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (elastic#92565) [Dashboard] Export appropriate references from byValue panels (elastic#91567) [Upgrade Assistant] Align code between branches (elastic#91862) [Security Solution][Case] Fix alerts push (elastic#91638) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the positioning of the date picker back and forward arrow buttons in the Anomaly detection start datafeed modal. Previously depending on the number of weeks in the calendar month, the modal height would change, which meant the position of the month forward / backward arrow buttons would change.
Before:
After:
Checklist
Fixes #81989