Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump handlebars from 4.7.6 to 4.7.7 #93396

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Bump handlebars from 4.7.6 to 4.7.7 #93396

merged 1 commit into from
Mar 3, 2021

Conversation

watson
Copy link
Contributor

@watson watson commented Mar 3, 2021 •
edited
Loading

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed v6.8.15 v7.11.2 labels Mar 3, 2021
@watson watson self-assigned this Mar 3, 2021
@watson watson force-pushed the bump-handlebars branch from 3c858da to 4eed016 Compare March 3, 2021 10:54
@watson watson marked this pull request as ready for review March 3, 2021 12:31
@watson watson requested a review from a team March 3, 2021 12:41
@watson
Copy link
Contributor Author

watson commented Mar 3, 2021

@elastic/kibana-core I'm not really sure who owns the handlebars dependency. I can see that it's being used in a lot of different plugins, so I guess it might fall under core.

@watson watson enabled auto-merge (squash) March 3, 2021 12:43
@watson
Copy link
Contributor Author

watson commented Mar 3, 2021

@elastic/kibana-operations can you please verify that it's ok for me to backport this to v7.12.0 as opposed to v7.12.1?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.4MB 1.4MB +39.0B
visTypeTimeseries 1.7MB 1.7MB +39.0B
total +78.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActionsEnhanced 217.5KB 217.5KB +39.0B

History

  • 💚 Build #110645 succeeded 3c858da440337951c8adde4422dc4884c7e9dd2f
  • 💔 Build #110636 failed 7fb592165adde57d1b51c3a908e377deb08d5c3a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson merged commit e42b0f9 into elastic:master Mar 3, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2021
@watson @kibanamachine
Bump handlebars from 4.7.6 to 4.7.7 (elastic#93396)
89f6b6a
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2021
@watson @kibanamachine
Bump handlebars from 4.7.6 to 4.7.7 (elastic#93396)
d5f5948
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 3, 2021
@watson @kibanamachine
Bump handlebars from 4.7.6 to 4.7.7 (elastic#93396)
76bdbd6
@kibanamachine kibanamachine mentioned this pull request Mar 3, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

❌ 6.8: Commit could not be cherrypicked due to conflicts
✅ 7.11 / #93413
✅ 7.12 / #93414
✅ 7.x / #93415

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 93396

kibanamachine added a commit that referenced this pull request Mar 3, 2021
@kibanamachine @watson
Bump handlebars from 4.7.6 to 4.7.7 (#93396) (#93413)
67994a9 
Co-authored-by: Thomas Watson <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 3, 2021
@kibanamachine @watson
Bump handlebars from 4.7.6 to 4.7.7 (#93396) (#93414)
5174f83 
Co-authored-by: Thomas Watson <[email protected]>
kibanamachine added a commit that referenced this pull request Mar 3, 2021
@kibanamachine @watson
Bump handlebars from 4.7.6 to 4.7.7 (#93396) (#93415)
95d46cd 
Co-authored-by: Thomas Watson <[email protected]>
watson added a commit to watson/kibana that referenced this pull request Mar 4, 2021
@watson
Bump handlebars from 4.7.6 to 4.7.7 (elastic#93396)
dfaefcb 
# Conflicts:
#	package.json
#	yarn.lock
@watson watson mentioned this pull request Mar 4, 2021
Merged
@watson
Copy link
Contributor Author

watson commented Mar 4, 2021

I had to manually resolve the conflicts in the 6.8 backport, which got quite involved as handlebars was a transient dependency of a few of our direct dependencies in 6.8 which is no longer in master. The backport PR is #93565

watson added a commit that referenced this pull request Mar 4, 2021
@watson
Bump handlebars from 4.7.6 to 4.7.7 (#93396) (#93565)
a37c3b5 
# Conflicts:
#	package.json
#	yarn.lock
@watson watson deleted the bump-handlebars branch March 4, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees

@watson watson

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v6.8.15 v7.11.2 v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watson @kibanamachine @mshustov