Amsterdam helpers #93701
Amsterdam helpers #93701
Conversation
ryankeairns
added
release_note:skip
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
LGTM! I tried all the combinations and they worked as expected. I got errors where expected as well. I'm not sure if the dark vs light differences are necessary since we still have lightOrDarkTheme() for that. But I suppose it doesn't hurt and the second param is optional.
I also checked that this works in both the @imported Sass files and those imported directly by JS.
The only thing that could be confusing to devs is if they forget about the KBN_OPTIMIZER_THEMES setting. When I flip the switch in advanced settings to K8 but I'm only building with v7, I'm still seeing the v7 compiled styles. But hopefully the 48 console errors will help them realize 😏 .
Co-authored-by: Caroline Horn <[email protected]>
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* Adds kbnThemeStyle mixin * Update src/core/public/core_app/styles/_mixins.scss Co-authored-by: Caroline Horn <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Caroline Horn <[email protected]>
* Adds kbnThemeStyle mixin * Update src/core/public/core_app/styles/_mixins.scss Co-authored-by: Caroline Horn <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Caroline Horn <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Caroline Horn <[email protected]>
Summary
Ah, Amsterdam. So close, yet so far away... Perhaps this mixin will help us get there!
(This is a joke about the distance to the city, from where I live, and lack of COVID travel. They say if you have to explain a joke, then it's probably not funny to begin with. You be the judge. I suspect they are right)
Credit to Andrea and her original PR for this solution. I've merely split off the mixin, so that we can make it available for folks to start on cleanup work. This also buys us more time to clean up the remaining query bar stuff.