Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination control to datavisualizer failures to rendering all errors at a single time #93839

Merged
merged 5 commits into from
Mar 11, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 5, 2021

To view problem:

  1. use ML data visualizer to import a file with lots of errors. For example, download https://alaska.usgs.gov/data/wildlifeTracking/bird/loon/yellowBilledLoon/argos/yellowBilledLoon_USGS_ASC_argos_processedData.zip from https://www.usgs.gov/centers/asc/science/tracking-data-yellow-billed-loons-gavia-adamsii?qt-science_center_objects=0#qt-science_center_objects. Unzip the file and import "processedData/yellowBilledLoon_USGS_ASC_argos_diag_filteredLocations.csv".
  2. everything runs fine until the import is finished and the results are rendered. Then the browser tries to render all 149066 failures and fails over.

This PR fixes the problem by adding a pagination control to failures so a reasonable amount of failures are rendered at a time.

Screen Shot 2021-03-05 at 1 57 19 PM

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@nreese
Copy link
Contributor Author

nreese commented Mar 8, 2021

@elasticmachine merge upstream

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese
Copy link
Contributor Author

nreese commented Mar 11, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1741 1742 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.4MB 6.4MB +930.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 91f7711 into elastic:master Mar 11, 2021
nreese added a commit to nreese/kibana that referenced this pull request Mar 11, 2021
…rors at a single time (elastic#93839)

* Add pagination control to datavisualizer errors to avoid crashing browser

* conditionally render pagination control

* tslint

Co-authored-by: Kibana Machine <[email protected]>
nreese added a commit that referenced this pull request Mar 11, 2021
…rors at a single time (#93839) (#94442)

* Add pagination control to datavisualizer errors to avoid crashing browser

* conditionally render pagination control

* tslint

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants