-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination control to datavisualizer failures to rendering all errors at a single time #93839
Conversation
Pinging @elastic/ml-ui (:ml) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…rors at a single time (elastic#93839) * Add pagination control to datavisualizer errors to avoid crashing browser * conditionally render pagination control * tslint Co-authored-by: Kibana Machine <[email protected]>
…rors at a single time (#93839) (#94442) * Add pagination control to datavisualizer errors to avoid crashing browser * conditionally render pagination control * tslint Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
To view problem:
This PR fixes the problem by adding a pagination control to failures so a reasonable amount of failures are rendered at a time.