Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Vislib Point Series updates #9388

Merged
merged 1 commit into from
Dec 6, 2016
Merged

[5.x] Vislib Point Series updates #9388

merged 1 commit into from
Dec 6, 2016

Conversation

elastic-jasper
Copy link
Contributor

Vislib Point Series updates

Backports PR #9044

Commit 1:
renaming x-axis to axis

moving y-axis methods inside axis class

updating handler to use Axis for yAxis as well

introducting 'type' property to differ between X and Y axis

joining x_axis and y_axis into a single class axis

  • splitting it into 3 subclasses (Axis, AxisLabels, AxisScale)
  • converting to ES6 classes + style fixes
  • adding more customization options

updating handler to work with new Axis class

  • allowing handler to have multiple category/value axes (array)

converting axis_title to ES6 classes and making it work with new axis

updating column layout to support left/right top/bottom positioning of axis

  • updating css min-widths to 1px (removing them breaks the code) as we dont want to reserve the space for axes that dont exist.

introducing AxisConfig class

adding ordered and values back to axis to make other parts of vislib working

renaming axis.scale to axis.axisScale

removing comments

adding scale type config

removing unnecesarry configs (never used)

adding point series chart type

updating all charts

introducing VisConfig class

moving wiggle, silluete and stacking to axis

fixing based on last spencers review

add label to zero filled values

allow custom values on catwegory axis

adding clip path

updating defaults to match current vislib implementation

seri.show parameter

vertical category axis positioning

fixing more issues

fixing broken pie charts

increasing default truncate length

fixing expandLastBucket option

Commit 2:
fixing selenium tests by increasing barHeightTolerance

Commit 3:
fixing axis alignment (1px off)

Commit 4:
fixing layout elements min-height to 0

Commit 5:
point radius should be calculated per chart

Commit 6:
adding clip path to circles

Commit 7:
seting min height 0 on axis

Commit 8:
adding background class

Commit 9:
fixing selenium tests

Commit 10:
update visualize legend to correctly check if it should show

Commit 11:
fixing based on CJs comments

Commit 12:
improving stacking of negative values

Commit 13:
updating class name to better match element

Commit 14:
fixing charts with mixed (negative/positive) values

Commit 15:
fixing test (stacking happens for grouped charts as well to handle negative values correctly)

Commit 16:
fixing based on CJs last comments

Commit 17:
fixing unstable selenium test

Backports PR #9044

**Commit 1:**
renaming x-axis to axis

moving y-axis methods  inside axis class

updating handler to use Axis for yAxis as well

introducting 'type' property to differ between X and Y axis

joining x_axis and y_axis into a single class axis
- splitting it into 3 subclasses (Axis, AxisLabels, AxisScale)
- converting to ES6 classes + style fixes
- adding more customization options

updating handler to work with new Axis class
- allowing handler to have multiple category/value axes (array)

converting axis_title to ES6 classes and making it work with new axis

updating column layout to support left/right top/bottom positioning of axis
- updating css min-widths to 1px (removing them breaks the code) as we dont want to reserve the space for axes that dont exist.

introducing AxisConfig class

adding ordered and values back to axis to make other parts of vislib working

renaming axis.scale to axis.axisScale

removing comments

adding scale type config

removing unnecesarry configs (never used)

adding point series chart type

updating all charts

introducing VisConfig class

moving wiggle, silluete and stacking to axis

fixing based on last spencers review

add label to zero filled values

allow custom values on catwegory axis

adding clip path

updating defaults to match current vislib implementation

seri.show parameter

vertical category axis positioning

fixing more issues

fixing broken pie charts

increasing default truncate length

fixing expandLastBucket option

* Original sha: ba74498
* Authored by ppisljar <[email protected]> on 2016-09-13T10:59:17Z

**Commit 2:**
fixing selenium tests by increasing barHeightTolerance

* Original sha: f27f8a1
* Authored by ppisljar <[email protected]> on 2016-11-22T09:40:25Z

**Commit 3:**
fixing axis alignment (1px off)

* Original sha: 3d6267e
* Authored by ppisljar <[email protected]> on 2016-11-22T12:19:37Z

**Commit 4:**
fixing layout elements min-height to 0

* Original sha: 619a495
* Authored by ppisljar <[email protected]> on 2016-11-22T12:20:20Z

**Commit 5:**
point radius should be calculated per chart

* Original sha: be16b14
* Authored by ppisljar <[email protected]> on 2016-11-22T13:35:27Z

**Commit 6:**
adding clip path to circles

* Original sha: 188131b
* Authored by ppisljar <[email protected]> on 2016-11-22T13:43:55Z

**Commit 7:**
seting min height 0 on axis

* Original sha: 231a58a
* Authored by ppisljar <[email protected]> on 2016-11-22T14:45:12Z

**Commit 8:**
adding background class

* Original sha: c41e672
* Authored by ppisljar <[email protected]> on 2016-11-22T15:27:02Z

**Commit 9:**
fixing selenium tests

* Original sha: ed1b330
* Authored by ppisljar <[email protected]> on 2016-11-22T15:27:40Z

**Commit 10:**
update visualize legend to correctly check if it should show

* Original sha: 9bd80be
* Authored by ppisljar <[email protected]> on 2016-11-23T10:33:06Z

**Commit 11:**
fixing based on CJs comments

* Original sha: 02a22d0
* Authored by ppisljar <[email protected]> on 2016-12-01T06:44:37Z

**Commit 12:**
improving stacking of negative values

* Original sha: 9d79d79
* Authored by ppisljar <[email protected]> on 2016-12-01T06:55:33Z

**Commit 13:**
updating class name to better match element

* Original sha: 628408d
* Authored by ppisljar <[email protected]> on 2016-12-01T06:56:11Z

**Commit 14:**
fixing charts with mixed (negative/positive) values

* Original sha: 682ab0b
* Authored by ppisljar <[email protected]> on 2016-12-01T09:44:49Z

**Commit 15:**
fixing test (stacking happens for grouped charts as well to handle negative values correctly)

* Original sha: 69a53ea
* Authored by ppisljar <[email protected]> on 2016-12-01T09:52:29Z

**Commit 16:**
fixing based on CJs last comments

* Original sha: 9e8d71f
* Authored by ppisljar <[email protected]> on 2016-12-01T16:05:31Z

**Commit 17:**
fixing unstable selenium test

* Original sha: f36b6fc
* Authored by ppisljar <[email protected]> on 2016-12-06T11:20:30Z
@ppisljar ppisljar merged commit 4b66537 into 5.x Dec 6, 2016
@epixa epixa deleted the jasper/backport/9044/5.x branch December 6, 2016 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants