Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Adding comparison to Throughput chart, Error rate chart, and Errors table #94204

Merged
merged 7 commits into from
Mar 16, 2021
Merged

[APM] Adding comparison to Throughput chart, Error rate chart, and Errors table #94204

merged 7 commits into from
Mar 16, 2021

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Mar 9, 2021 •
edited
Loading

closes #90573
closes #90584

Screen Shot 2021-03-10 at 15 24 12

Screen Shot 2021-03-10 at 15 23 31

Screen Shot 2021-03-10 at 15 24 33

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 apm:comparison labels Mar 9, 2021
@cauemarcondes cauemarcondes force-pushed the apm-comparison-throuput-error-rate branch from 852102d to 2bb465e Compare March 10, 2021 19:40
@cauemarcondes cauemarcondes marked this pull request as ready for review March 10, 2021 20:28
@cauemarcondes cauemarcondes requested a review from a team as a code owner March 10, 2021 20:28
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Mar 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte
Copy link
Contributor

ogupte commented Mar 11, 2021 •
edited
Loading

does it make sense to default the previous impact to 0 in the transactions table?

kibana/x-pack/plugins/apm/public/components/app/service_overview/service_overview_transactions_table/get_columns.tsx

Lines 161 to 163 in 2bb465e

const previousImpact =
transactionGroupComparisonStatistics?.previousPeriod?.[name]
?.impact ?? 0;

I feel that it shouldn't be rendered at all if that's the case since 0 means something different.

ogupte
ogupte approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@cauemarcondes
Copy link
Contributor Author

jenkins, retest this please

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.3MB 5.3MB +2.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit b0fa077 into elastic:master Mar 16, 2021
@cauemarcondes cauemarcondes deleted the apm-comparison-throuput-error-rate branch March 16, 2021 13:12
@cauemarcondes cauemarcondes mentioned this pull request Mar 16, 2021
Merged
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Mar 16, 2021
@cauemarcondes @kibanamachine
[APM] Adding comparison to Throughput chart, Error rate chart, and Er…
99186d3 
…rors table (elastic#94204)

* adding comparison to throuput chart

* adding comparison to error rate chart

* adding comparison to errors table

* fixing/adding api test

* addressing pr comments

* addressing pr comments

Co-authored-by: Kibana Machine <[email protected]>
cauemarcondes added a commit that referenced this pull request Mar 16, 2021
@cauemarcondes @kibanamachine
[APM] Adding comparison to Throughput chart, Error rate chart, and Er…
d488ef5 
…rors table (#94204) (#94695)

* adding comparison to throuput chart

* adding comparison to error rate chart

* adding comparison to errors table

* fixing/adding api test

* addressing pr comments

* addressing pr comments

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@ogupte ogupte self-assigned this May 10, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

Assignees

@ogupte ogupte

Labels
apm:comparison apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Add comparison data to Error rate chart [APM] Adding comparison to errors table
4 participants
@cauemarcondes @elasticmachine @ogupte @kibanamachine