-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY_SOLUTION][ENDPOINT] Create artifact manifests with new relative URL (if fleet-server is enabled) #94499
[SECURITY_SOLUTION][ENDPOINT] Create artifact manifests with new relative URL (if fleet-server is enabled) #94499
Conversation
uses ManifestManager new static method to retrieve it instead
…ke it up into individual handlers
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
@@ -0,0 +1,121 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was both a rename (used to be called ingest_integration
as well as a refactor. Prior version had all logic for the action that are taken in this module. Those have now been split up into separate modules (under ./handler/**
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the handlers largely the same after the refactor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - I just moved the code over. tests - which use the fleet_integration
module - were unchanged.
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 for the export { relativeDownloadUrlFromArtifact } from './services/artifacts/mappings';
changes in fleet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to add this to the list of things to remove when we delete agents route (one day) #94303
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Good point @nchaulet . I added a reference to this PR in the item already listed there |
…tive URL (if fleet-server is enabled) (#94499) (#94637) * When xpack.securitySolution.fleetServerEnabled is true, then Endpoint artifact manifest will use a fleet-server relative url for the artifacts generated (note: this flag is temporary until we ship v7.13) * Refactors the security solution fleet integration extension point callbacks so that some action handlers can be executed in parallel (the creation of detection engine prepackaged rules can sometime take some time to complete
Summary
xpack.securitySolution.fleetServerEnabled
istrue
, then Endpoint artifact manifest will use afleet-server
relative url for the artifacts generated (note: this flag is temporary until we ship v7.13)Example of Manifest Policy data when Fleet Server is enabled:
Checklist