[eslint] re-enable no-var and prefer-const #9455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tylersmalley
approved these changes
Dec 13, 2016
|
/giphy for the love of |
7 tasks
|
Is this supposed to get backported? I seem to get a lot of backport conflicts because of let/const differences. |
|
Hmm, it's labeled 5.2 but I don't see the backport here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables the no-var and prefer-const rules in eslint and fixes all violations. All but the last commit contains fixes automatically generated by the
npm run lintrollercommand. The final commit fixes the violations that were not auto-fixable for some reason. None of the changes were very significant and should be easy to review for correctness.