Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint] reenable no-extra-semi and quotes rules #9473

Merged
merged 3 commits into from
Dec 14, 2016
Merged

[eslint] reenable no-extra-semi and quotes rules #9473

merged 3 commits into from
Dec 14, 2016

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 13, 2016

This PR just reenabled the no-extra-semi and quotes rules, and all violations are auto-fixable!

If you have a pr that is failing these rules, just run npm run lintroller to fix the violations.

@thomasneirynck thomasneirynck self-assigned this Dec 14, 2016
thomasneirynck
thomasneirynck approved these changes Dec 14, 2016
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after skimming, seems to have fixed all semi-colons.

didn't know of existence of the lintroller-task, it's a nifty tool!

tylersmalley
tylersmalley approved these changes Dec 14, 2016
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit e488a16 into elastic:master Dec 14, 2016
@spalger spalger deleted the eslint/reenable/no-extra-semi+quotes branch December 14, 2016 01:23
@spalger spalger mentioned this pull request Dec 14, 2016
Closed
7 tasks
@epixa epixa added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Dec 16, 2016
@spalger spalger mentioned this pull request Feb 1, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees

@thomasneirynck thomasneirynck

Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v5.2.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @tylersmalley @thomasneirynck @epixa