[5.x] [grunt/eslint] fix precommit linting #9532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #9510 **Commit 1:** [grunt/eslint] fix precommit linting - remove use of `minimatch.makeRe()` because it does not support the entire glob syntax - log a warning whenever a js file is excluded by the `lintStagedFiles` task - eslint globs are relative to the project root, ensure that we check against relative version * Original sha: ca45ae2 * Authored by spalger <[email protected]> on 2016-12-15T19:01:21Z **Commit 2:** [grunt/eslint] only log warning wtr grunt paths * Original sha: b152e35 * Authored by spalger <[email protected]> on 2016-12-15T21:45:40Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[grunt/eslint] fix precommit linting
Backports PR #9510
Commit 1:
[grunt/eslint] fix precommit linting
minimatch.makeRe()because it does not support the entire glob syntaxlintStagedFilestaskCommit 2:
[grunt/eslint] only log warning wtr grunt paths