Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly detection job selection resolver for embeddables #95394

Merged
merged 2 commits into from
Mar 25, 2021
Merged

[ML] Anomaly detection job selection resolver for embeddables #95394

merged 2 commits into from
Mar 25, 2021

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Mar 25, 2021 •
edited by peteharverson
Loading

Summary

Related issue #66553

There are more embeddable types for Anomaly detection on the way, we need a reusable job selector.
This PR extracts common logic for job selection from the Anomaly swim lane input resolver.

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 25, 2021
@darnautov darnautov requested a review from a team as a code owner March 25, 2021 10:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@qn895
Copy link
Member

qn895 commented Mar 25, 2021

Tested and LGTM

peteharverson
peteharverson approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov enabled auto-merge (squash) March 25, 2021 14:52
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1743 1744 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +176.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit a8b04d7 into elastic:master Mar 25, 2021
@darnautov darnautov deleted the ML-job-selection-resolver branch March 25, 2021 15:23
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 25, 2021
@darnautov @kibanamachine
[ML] Extract job selection resolver (elastic#95394)
e7a158e
@kibanamachine kibanamachine mentioned this pull request Mar 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.x / #95419

This backport PR will be merged automatically after passing CI.

@qn895 qn895 mentioned this pull request Mar 25, 2021
Merged
6 tasks
kibanamachine added a commit that referenced this pull request Mar 25, 2021
@kibanamachine @darnautov
[ML] Extract job selection resolver (#95394) (#95419)
5bfd5f9 
Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @qn895 @kibanamachine @peteharverson