Switch Tinymath to use peggy instead of pegjs #97906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mistic
reviewed
Apr 21, 2021
|
@mistic This library is used in a few other places in Kibana. I am working on a separate PR which updates all of them at once, but I think this PR is lower risk. |
|
Btw @wylieconlon congrats on the initiative to update the Bazel build file on your own 😄 |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
lukeelmers
approved these changes
Apr 21, 2021
flash1293
approved these changes
Apr 22, 2021
wylieconlon
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 22, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 22, 2021
Co-authored-by: Wylie Conlon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are migrating all pegjs usage as the previous library has stopped being maintained. See discussion #97504 for more context.
As the new library is backwards compatible, this should be minimal impact.