Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Fixes dashboard_save functional test #98830

Merged
merged 2 commits into from
May 17, 2021
Merged

[Dashboard] Fixes dashboard_save functional test #98830

merged 2 commits into from
May 17, 2021

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 29, 2021

Summary

Fixes #89476.

This fixes the test for quick saving in Dashboard. The save button was disabled bc there were no changes made to the dashboard before attempting to save, and thus failing to display the save dashboard toast notification. This adds a markdown panel to the dashboard before saving.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added chore Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.14.0 v7.13.0 labels Apr 29, 2021
@cqliu1 cqliu1 requested a review from a team as a code owner April 29, 2021 20:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson
ThomThomson approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code only review - this fix looks great. The new error will help us diagnose these way faster in the future. Really nice!

LGTM

@cqliu1
Copy link
Contributor Author

cqliu1 commented May 17, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 removed the v7.13.0 label May 17, 2021
@cqliu1 cqliu1 merged commit 9aa7892 into elastic:master May 17, 2021
@cqliu1 cqliu1 deleted the fix/dashboard_save_test branch May 17, 2021 16:46
cqliu1 added a commit to cqliu1/kibana that referenced this pull request May 17, 2021
@cqliu1 @kibanamachine
[Dashboard] Fixes dashboard_save functional test (elastic#98830)
01da3e7 
Co-authored-by: Kibana Machine <[email protected]>
@cqliu1 cqliu1 mentioned this pull request May 17, 2021
Merged
cqliu1 added a commit that referenced this pull request May 17, 2021
@cqliu1 @kibanamachine
[Dashboard] Fixes dashboard_save functional test (#98830) (#100227)
3124344 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@cqliu1 @kibanamachine @yctercero
[Dashboard] Fixes dashboard_save functional test (elastic#98830)
a641c8b 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
chore Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@cqliu1 @elasticmachine @kibanamachine @ThomThomson