-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use doc link services in rollups #99137
Conversation
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for making those changes @lcawl 👍
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
Summary
Related to #88107
This PR removes hard-coded links from https://github.com/elastic/kibana/blob/master/x-pack/plugins/rollup/public/crud_app/services/documentation_links.js, replacing them with keywords from the documentation link service. The changes to the individual *.js files are based on changes in #98436
NOTE: The URL used in several of the links (https://www.elastic.co/guide/en/elasticsearch/reference/master/rollup-job-config.html) is a deleted page. The new keyword therefore uses the replacement URL (https://www.elastic.co/guide/en/elasticsearch/reference/master/rollup-put-job.html#rollup-put-job-api-request-body).
Screenshots
Date histogram docs:
Cron expression docs:
Logistics docs: