Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doc link services in rollups #99137

Merged
merged 8 commits into from
May 10, 2021
Merged

Use doc link services in rollups #99137

merged 8 commits into from
May 10, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 3, 2021

Summary

Related to #88107

This PR removes hard-coded links from https://github.com/elastic/kibana/blob/master/x-pack/plugins/rollup/public/crud_app/services/documentation_links.js, replacing them with keywords from the documentation link service. The changes to the individual *.js files are based on changes in #98436

NOTE: The URL used in several of the links (https://www.elastic.co/guide/en/elasticsearch/reference/master/rollup-job-config.html) is a deleted page. The new keyword therefore uses the replacement URL (https://www.elastic.co/guide/en/elasticsearch/reference/master/rollup-put-job.html#rollup-put-job-api-request-body).

Screenshots

Date histogram docs:
image

Cron expression docs:
image

Logistics docs:
image

@lcawl
Copy link
Contributor Author

lcawl commented May 6, 2021

@elasticmachine merge upstream

@lcawl lcawl added Feature:Rollups v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes enhancement New value added to drive a business result and removed WIP Work in progress labels May 6, 2021
@lcawl lcawl marked this pull request as ready for review May 6, 2021 16:56
@lcawl lcawl requested review from a team as code owners May 6, 2021 16:56
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making those changes @lcawl 👍

@lcawl
Copy link
Contributor Author

lcawl commented May 10, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
rollup 229.3KB 229.5KB +173.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 400.8KB 400.9KB +97.0B
rollup 41.9KB 40.8KB -1.0KB
total -944.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit c787495 into elastic:master May 10, 2021
@lcawl lcawl deleted the rollup-links branch May 10, 2021 17:01
lcawl added a commit to lcawl/kibana that referenced this pull request May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants