[5.x] Introduce custom modal confirmation dialogs #9958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #9859 **Commit 1:** Introduce custom modal confirmation dialogs * Original sha: 6b727df * Authored by Stacey Gammon <[email protected]> on 2017-01-13T15:56:44Z **Commit 2:** address code review comments and implement new angular style suggestions from Joe * Original sha: 5ca36df * Authored by Stacey Gammon <[email protected]> on 2017-01-13T22:12:44Z **Commit 3:** refactor no point making vanilla code that's really only going to work with angular i guess... also broke apart the confirm modal from the injector, and made safeConfirm just use the confirm modal * Original sha: ce783b2 * Authored by Joe Fleming <[email protected]> on 2017-01-14T01:09:52Z * Committed by Stacey Gammon <[email protected]> on 2017-01-17T14:30:21Z **Commit 4:** Clean up from merge - Move safe_confirm into modals folder - make data-test-subj camelCase. - get rid of $timeout call, doesn’t seem necessary anymore, now that window.confirm is not being used. * Original sha: c91fbc6 * Authored by Stacey Gammon <[email protected]> on 2017-01-16T15:00:14Z **Commit 5:** Fix tests * Original sha: e581374 * Authored by Stacey Gammon <[email protected]> on 2017-01-16T15:42:41Z **Commit 6:** Use ui-framework styles * Original sha: d1e2b12 * Authored by Stacey Gammon <[email protected]> on 2017-01-17T15:22:52Z **Commit 7:** Address latest round of comments and remove adoption of new patterns. * Original sha: 0b690f1 * Authored by Stacey Gammon <[email protected]> on 2017-01-17T20:00:52Z **Commit 8:** Improve error message. Use sinon in tests. * Original sha: 92f815d * Authored by Stacey Gammon <[email protected]> on 2017-01-17T20:07:22Z **Commit 9:** Focus on the confirm button by default * Original sha: 27be4df * Authored by Stacey Gammon <[email protected]> on 2017-01-18T14:17:44Z **Commit 10:** Indent message * Original sha: 3dc6c93 * Authored by Stacey Gammon <[email protected]> on 2017-01-18T22:04:49Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce custom modal confirmation dialogs
Backports PR #9859
Commit 1:
Introduce custom modal confirmation dialogs
Commit 2:
address code review comments
and implement new angular style suggestions from Joe
Commit 3:
refactor
no point making vanilla code that's really only going to work with angular i guess...
also broke apart the confirm modal from the injector, and made safeConfirm just use the confirm modal
Commit 4:
Clean up from merge
window.confirm is not being used.
Commit 5:
Fix tests
Commit 6:
Use ui-framework styles
Commit 7:
Address latest round of comments and remove adoption of new patterns.
Commit 8:
Improve error message. Use sinon in tests.
Commit 9:
Focus on the confirm button by default
Commit 10:
Indent message