Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asciidoctor support again #691

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Asciidoctor support again #691

merged 1 commit into from
Apr 30, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 30, 2019

Break another multi-valued conditional into two so Asciidoctor can use
it.

@nik9000
Asciidoctor support again
011d177 
Break another multi-valued conditional into two so Asciidoctor can use
it.
@nik9000 nik9000 requested review from dedemorton and karenzone April 30, 2019 17:03
@dedemorton
Copy link
Contributor

I think it's sufficient for Karen to review these PRs, so I'm removing myself from the reviewer list.

@dedemorton dedemorton removed their request for review April 30, 2019 17:31
@nik9000 nik9000 mentioned this pull request Apr 30, 2019
Merged
@nik9000
Copy link
Member Author

nik9000 commented Apr 30, 2019

I think it's sufficient for Karen to review these PRs, so I'm removing myself from the reviewer list.

Cool.

karenzone
karenzone approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and LGTM. Thanks!

@nik9000 nik9000 merged commit 1ba1d9a into versioned_plugin_docs Apr 30, 2019
@nik9000
Copy link
Member Author

nik9000 commented Apr 30, 2019

Thanks for reviewing @karenzone!

@nik9000 nik9000 mentioned this pull request Apr 30, 2019
Merged
@jsvd jsvd deleted the ascicidoctorify3 branch November 25, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @dedemorton @karenzone