Comment out LS config examples that no longer work #10671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karenzone After creating this PR, I decided that maybe we should leave the docs in their current state as motivation to get them updated rather than commenting out the incorrect sections. WDYT? I'm gonna leave it up to you to decide. I think the updates are just a matter of looking at the list of changed fields and updating the configs accordingly. |
|
@karenzone Are you interested in making these changes, or should I just close this PR? |
|
@dedemorton Thank you for doing this. I want to get this fixed SOON, but this is the right approach for now. |
karenzone
approved these changes
May 9, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
May 9, 2019
elasticsearch-bot
pushed a commit
that referenced
this pull request
May 9, 2019
|
@karenzone it seems this PR didn't land on 7.x, do you see any issues with backporting it? |
karenzone
pushed a commit
to karenzone/logstash
that referenced
this pull request
May 11, 2021
karenzone
pushed a commit
to karenzone/logstash
that referenced
this pull request
May 11, 2021
karenzone
pushed a commit
to karenzone/logstash
that referenced
this pull request
May 11, 2021
This was referenced May 11, 2021
karenzone
added a commit
that referenced
this pull request
May 11, 2021
Backports #10671 Co-authored-by: dedemorton <[email protected]>
karenzone
added a commit
that referenced
this pull request
May 11, 2021
Backports #10671 Co-authored-by: dedemorton <[email protected]>
karenzone
added a commit
that referenced
this pull request
May 11, 2021
Backports #10671 Co-authored-by: dedemorton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration examples that we show in the Logstash docs no longer work because they use the old field names instead of the ECS names.
I would like for us to replace the examples with working configs because I think they are useful not just for FB users, but for anyone who wants to see working examples of LS configs.
If we decide not to replace the examples, I would suggest making all the content a single topic rather than having a nested hierarchy.
@karenzone I have not set up redirects because I hope we can get this content fixed soonish.