Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ruby execution engine #12490

Closed
wants to merge 8 commits into from

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Dec 1, 2020

Fixed: #11236

This PR removes the Ruby Execution Engine
The Java Execution Engine has been the default engine since Logstash 7.0, and is capable of using plugins written in either Ruby or Java; removing the Ruby Execution Engine will not affect our ability to run existing pipelines, but will greatly reduce the surface area of all features and fixes within the engine(s). We will no longer need to target two engines simultaneously.

Ruby execution engine uses Treetop to parse Logstash config files and convert them to executable code which is being referenced by Java pipeline, so Treetop stays in the project.

  • remove Logstash::Pipeline
  • rewrite test cases which depend on ruby pipeline
  • remove logstash/event, Logstash::SignalEvent
  • remove Engine.Ruby on java side
  • remove config pipeline.java_execution

This PR will split into three smaller to feature branch for review
#12496 remove Logstash::Pipeline, Engine.Ruby, rewrite test cases
#12505 remove Logstash::SignalEvent
#12506 remove config pipeline.java_execution

A follow up will be removing logstash/pipeline in logstash-devutils

@kaisecheng kaisecheng requested a review from andsel December 3, 2020 13:43
@kaisecheng
Copy link
Contributor Author

move the PR to #12517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ruby execution
1 participant