-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility on ruby pipeline for plugins not in support matrix #12534
Add compatibility on ruby pipeline for plugins not in support matrix #12534
Conversation
It is unclear to me how this "adds a better backward compatibility experience for plugins not in the support matrix".
|
I check this page to differentiate the plugins we are actively maintaining. For tier 1 & 2 plugins, all |
The test cases like this will be beneficial. So, we don't need to change the test cases in every project and keep them running |
@yaauie I was the one to suggest this due a few The require seemed legit (loading whatever pipeline there is in LS not tying things to a "java" pipeline), although it's questionable why anyone except the devutils case would need to require this. Seemed like worth saving a few hops but given it's only present one of the supported plugins (integration-rabbitmq) I have not strong feelings about this. |
@yaauie Do you have a further concern? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixed: elastic#11236 (cherry picked from commit 6a28ac1)
Fixed: #11236 (cherry picked from commit 6a28ac1) Co-authored-by: kaisecheng <[email protected]>
[rn:skip]
This PR is a follow-up of ruby execution engine removal. It adds a better backward compatibility experience for plugins not in the support matrix
follow-up on #12517