Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #12791 to 7.x: Deps: update JRuby to 9.2.18.0 #12971

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Jun 9, 2021

Backport PR #12791 to 7.x branch. Original message:

Version bump of JRuby.

Release notes

Includes upstream fixes for ARM64 support.

What does this PR do?

Dependency update, release notes (since 9.2.16.0):
https://www.jruby.org/2021/03/29/jruby-9-2-17-0.html
https://www.jruby.org/2021/06/08/jruby-9-2-18-0.html

JRuby 9.2.18.0 include JNR fixes for ARM64: jnr/jnr-ffi#240 jnr/jnr-posix#165

Checklist

Author's Checklist

  • a potential blocker due LS' reuse of vendor/jruby/bin/jruby e.g. from bin/logstash-plugin
    (present in 9.2.17.0 but resolved in 9.2.18.0)
  • another suspicious issue with String#split

Related issues

#12077 (unfortunately the auto-load fixes were not backported to RGs 3.1)

+ Fix: a missing require in bootstrap

(cherry picked from commit ee6038a)
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green build

@kares
Copy link
Contributor Author

kares commented Jun 9, 2021

there's a new failure due Bundler 1.17 using deprecated Rubygems API (JRuby did update RGs in 9.2.17.0)

11:53:02     Failures:
11:53:02 
11:53:02       1) CLI > logstash-plugin prepare-offline-pack create a pack from a wildcard successfully create a pack
11:53:02          Failure/Error: expect(unpacked.plugins.collect(&:name)).to include(*filters)
11:53:02            expected ["logstash-filter-uuid", "logstash-filter-qatest", "logstash-filter-useragent", "logstash-filter-diss...ogstash-filter-truncate", "logstash-filter-memcached", "logstash-filter-ruby", "logstash-filter-kv"] to include "/opt/logstash/build/logstash-7.14.0-SNAPSHOT/vendor/bundle/jruby/2.5.0/gems/bundler-1.17.3/lib/bundler/rubygems_integration.rb:200: warning: constant Gem::ConfigMap is deprecated"
11:53:02          # ./specs/cli/prepare_offline_pack_spec.rb:92:in `block in <main>'
11:53:02          # /opt/logstash/build/qa/integration/vendor/jruby/2.5.0/gems/rspec-wait-0.0.9/lib/rspec/wait.rb:46:in `block in <main>'
11:53:02          # ./rspec.rb:32:in `<main>'
11:53:02 
11:53:02     Finished in 14 minutes 35 seconds (files took 5.26 seconds to load)
11:53:02     31 examples, 1 failure
11:53:02 
11:53:02     Failed examples:
11:53:02 
11:53:02     rspec ./specs/cli/prepare_offline_pack_spec.rb:77 # CLI > logstash-plugin prepare-offline-pack create a pack from a wildcard successfully create a pack
11:53:02 
11:53:02     Randomized with seed 24495

* 7.x:
  Test: handle a RGs warning from packing output (elastic#12974)
@kares kares merged commit 419b1dc into elastic:7.x Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants