Removed JAVA_HOME using only LS_JAVA_HOME #13214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
roaksoax
approved these changes
Sep 14, 2021
Updated all the Logstash launching scripts to use only LS_JAVA_HOME as environment variable to determine the JDK to use to launch Logstash. JAVA_HOME is abandoned for this job.
andsel
force-pushed
the
feature/remove_java_home_8.0
branch
from
c6e9d9a to
9c82909
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't backport to 7.x
Release notes
Logstash's launch script support LS_JAVA_HOME and abandon the JAVA_HOME.
It's the path to an installed JDK to be used to launch Logstash's service and support tools.
JAVA_HOME is not anymore looked at, only LS_JAVA_HOME.
What does this PR do?
Removes the usage of JAVA_HOME completely, that environment variable is not anymore used for JDK path resolution.
Updated all the Logstash launching scripts to use only LS_JAVA_HOME as environment variable to
determine the JDK to use to launch Logstash. JAVA_HOME is abandoned for this job.
Why is it important/What is the impact to the user?
Already with PR #13204
JAVA_HOMEwas considered deprecated, this is important for the user because let them to separate JDKs for each JVM process, without implicit interference with the globalJAVA_HOME.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
Use same testing path described in #13204
Related issues
Use cases
Screenshots
Logs