Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes not Kilobytes #2539

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Bytes not Kilobytes #2539

merged 1 commit into from
Jun 20, 2023

Conversation

davidkyle
Copy link
Member

Max RSS returned by macOS getrusage is in bytes not kilobytes.

The man page for getrusage on my mac (Ventura 13.4) states this:

ru_maxrss    the maximum resident set size utilized (in bytes).

I think the confusion arose because a search for macOS getrusage takes you to the IOS man page where the ru_maxrss field is in KB not B

Non issue as this code is not in any public release yet.

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged commit 1d29863 into elastic:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants