[ML] Standardise use of type aliases and rvalue references in for loops #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2018
tveasey
added a commit
that referenced
this pull request
Apr 4, 2018
We currently use a mixture of type aliases and typedefs in our code. Since type aliasing provides a strict superset of the functionality of typedefs, but is otherwise essentially equivalent, it seems sensible to standardise on only using type aliasing throughout. This also adopts the convention of not using rvalue references in for loops, except for template code, on grounds of readability.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
We currently use a mixture of type aliases and typedefs in our code. Since type aliasing provides a strict superset of the functionality of typedefs, but is otherwise essentially equivalent, it seems sensible to standardise on only using type aliasing throughout. This also adopts the convention of not using rvalue references in for loops, except for template code, on grounds of readability.
droberts195
pushed a commit
that referenced
this pull request
Apr 23, 2018
We currently use a mixture of type aliases and typedefs in our code. Since type aliasing provides a strict superset of the functionality of typedefs, but is otherwise essentially equivalent, it seems sensible to standardise on only using type aliasing throughout. This also adopts the convention of not using rvalue references in for loops, except for template code, on grounds of readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of a couple of changes related to C++11 language features. With the big change related to automating formatting upcoming, I plan to make these now.
We currently use a mixture of type aliases and typedefs in our code. Since type aliasing provides a strict superset of the functionality of typedefs, but is otherwise essentially equivalent, it seems sensible to standardise on only using type aliasing throughout. This PR makes that change.
It also adopts the convention of not using rvalue references in for loops, except for template code, on grounds of readability.