-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent.monitoring.pprof doc #1265
Merged
michel-laterman
merged 2 commits into
elastic:main
from
michel-laterman:agent-monitoring-pprof
Nov 22, 2021
Merged
Add agent.monitoring.pprof doc #1265
michel-laterman
merged 2 commits into
elastic:main
from
michel-laterman:agent-monitoring-pprof
Nov 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some explanation for the agent.monitoring.pprof option, and when to disable it, in the stand-alone documentation.
michel-laterman
added
the
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
label
Nov 16, 2021
5 tasks
A documentation preview will be available soon: |
dedemorton
reviewed
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution. A few edits/suggests. Nice work!
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/elastic-agent/configuration/elastic-agent-monitoring.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: DeDe Morton <[email protected]>
dedemorton
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing.
michel-laterman
added a commit
to michel-laterman/observability-docs
that referenced
this pull request
Nov 22, 2021
* Add agent.monitoring.pprof doc Add some explanation for the agent.monitoring.pprof option, and when to disable it, in the stand-alone documentation. * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
michel-laterman
added a commit
to michel-laterman/observability-docs
that referenced
this pull request
Nov 22, 2021
* Add agent.monitoring.pprof doc Add some explanation for the agent.monitoring.pprof option, and when to disable it, in the stand-alone documentation. * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
michel-laterman
added a commit
that referenced
this pull request
Nov 23, 2021
* Add agent.monitoring.pprof doc Add some explanation for the agent.monitoring.pprof option, and when to disable it, in the stand-alone documentation. * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
michel-laterman
added a commit
that referenced
this pull request
Nov 23, 2021
* Add agent.monitoring.pprof doc Add some explanation for the agent.monitoring.pprof option, and when to disable it, in the stand-alone documentation. * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
bmorelli25
pushed a commit
to bmorelli25/observability-docs
that referenced
this pull request
Apr 11, 2023
* Add agent.monitoring.pprof doc Add some explanation for the agent.monitoring.pprof option, and when to disable it, in the stand-alone documentation. * Apply suggestions from code review Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some explanation for the agent.monitoring.pprof option, and when to
disable it, in the stand-alone documentation.