Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update ingest management docs with 7.9 UI changes #80

Merged
merged 5 commits into from
Aug 8, 2020

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Aug 4, 2020

Closes #40

Requires elastic/beats#20437

Here's the preview: https://observability-docs_80.docs-preview.app.elstc.co/guide/en/ingest-management/master/index.html (note that the install shows version 8.0.0, but that will be corrected when I backport this PR to 7.9).

REVIEWERS: Our tabbed panels are evolving. We need to inject the HTML directly into the build right now, but that will change in the future. For now, the best way to review the content there is to look at the rendered content in the preview.

TODOs:

  • Test commands on all platforms (macOS has been tested; other platforms mimic beats) DeDe-mac/Eric-other platforms

@dedemorton dedemorton added docs Improvements or additions to documentation v7.9.0 v7.9.0 v7.10.0 v7.10.0 labels Aug 4, 2020
@apmmachine
Copy link
Contributor

A docs preview will be available soon:
- HTML diff
- Observability guide

@dedemorton dedemorton marked this pull request as ready for review August 6, 2020 01:27
@dedemorton dedemorton self-assigned this Aug 6, 2020
@dedemorton
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

Copy link
Contributor

@EricDavisX EricDavisX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - I think we have 2-3 more important and a few smaller adjustments we can make now or later, I have doc'ed them here: #90

  • if you want to merge as is, that's ok and we can iterate.

The docs are looking wonderful overall, thanks for the great work!!!

@dedemorton
Copy link
Contributor Author

OK I'll merge to get these in and we can iterate. Thanks!

@dedemorton dedemorton merged commit ce577d7 into elastic:master Aug 8, 2020
@dedemorton dedemorton deleted the issue#40 branch August 8, 2020 04:38
@dedemorton dedemorton removed the request for review from mostlyjason August 8, 2020 04:39
@dedemorton
Copy link
Contributor Author

@hbharding @mostlyjason Please add comments to Eric's issue if you see other things that need to be changed. I think it's useful to merge this now so folks won't be confused about which topics still need to be updated. See #90

dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Aug 8, 2020
* [docs] Update ingest management docs with 7.9 UI changes

* Update ingest management docs with other 7.9 changes

* Reference local copy of js/css

* Fix bug in platform selector

* Minor edit to match agent docs
dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Aug 8, 2020
* [docs] Update ingest management docs with 7.9 UI changes

* Update ingest management docs with other 7.9 changes

* Reference local copy of js/css

* Fix bug in platform selector

* Minor edit to match agent docs
dedemorton added a commit that referenced this pull request Aug 9, 2020
…91)

* [docs] Update ingest management docs with 7.9 UI changes (#80)

* [docs] Update ingest management docs with 7.9 UI changes

* Update ingest management docs with other 7.9 changes

* Reference local copy of js/css

* Fix bug in platform selector

* Minor edit to match agent docs

* Remove release-state override
dedemorton added a commit that referenced this pull request Aug 9, 2020
…92)

* [docs] Update ingest management docs with 7.9 UI changes (#80)

* [docs] Update ingest management docs with 7.9 UI changes

* Update ingest management docs with other 7.9 changes

* Reference local copy of js/css

* Fix bug in platform selector

* Minor edit to match agent docs

* Remove release-state override
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
* [docs] Update ingest management docs with 7.9 UI changes

* Update ingest management docs with other 7.9 changes

* Reference local copy of js/css

* Fix bug in platform selector

* Minor edit to match agent docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v7.9.0 v7.9.0 v7.10.0 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ingest Manager docs with UI changes
3 participants