Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional categories #534

Merged
merged 5 commits into from
Jun 24, 2020
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jun 22, 2020

In the process of defining our integrations page, additional categories were defined: https://www.elastic.co/integrations This PR adds these categories to the registry.

It must be followed up to update all existing packages and then remove the old category definitions.

@ruflin
Copy link
Contributor Author

ruflin commented Jun 22, 2020

@ph @mostlyjason @mtojek @andresrc The above means we should update all the packages with the related categories. Please reach out to @mostlyjason for the correct mapping.

@mostlyjason Can you validate the the category list is correct?

util/package.go Show resolved Hide resolved
@ruflin ruflin self-assigned this Jun 22, 2020
@ruflin ruflin added the Ingest Management:beta1 Group issues for ingest management beta1 label Jun 22, 2020
@elasticmachine
Copy link

elasticmachine commented Jun 22, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #534 updated]

  • Start Time: 2020-06-24T07:01:05.825+0000

  • Duration: 8 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 127
Skipped 0
Total 127

@mtojek
Copy link
Contributor

mtojek commented Jun 23, 2020

@mostlyjason Please create an issue in the integrations repository with updated categories for packages. We can pick it up from there.

@ruflin ruflin force-pushed the add-more-categories branch from 40b253b to 1580df3 Compare June 23, 2020 09:02
@ruflin ruflin requested review from mostlyjason and mtojek June 23, 2020 09:03
@ruflin ruflin force-pushed the add-more-categories branch from 1580df3 to d5c0158 Compare June 23, 2020 11:17
@mostlyjason
Copy link

Thanks I left a comment on a separate thread discussing a new category field. I proposed that we move forward with this PR and come back later to update the categories if needed. Lets give a day or two to see if there are any objections.

@ruflin ruflin force-pushed the add-more-categories branch 2 times, most recently from f1ad258 to eeee8d4 Compare June 23, 2020 18:09
util/package.go Outdated Show resolved Hide resolved
ruflin added 5 commits June 24, 2020 09:00
In the process of defining our integrations page, additional categories were defined: https://www.elastic.co/integrations This PR adds these categories to the registry.

It must be followed up to update all existing packages and then remove the old category definitions.
@ruflin ruflin force-pushed the add-more-categories branch from eeee8d4 to 5eeb73d Compare June 24, 2020 07:00
@ruflin ruflin merged commit bc2c38d into elastic:master Jun 24, 2020
@ruflin
Copy link
Contributor Author

ruflin commented Jun 24, 2020

@mostlyjason Merged this PR so we can move forward with the changes in the packages but happy to follow up if you find more issues in the category names.

@ruflin ruflin deleted the add-more-categories branch June 24, 2020 07:27
ruflin added a commit to ruflin/package-storage that referenced this pull request Jun 30, 2020
The logs and metrics categories do not exist anymore. In elastic/package-registry#534 the supported categories were updated.

The categories are removed for now to allow the registry to remove the legacy support for these categories. The new releases of these packages must contain the new categories.
ruflin added a commit to elastic/package-storage that referenced this pull request Jun 30, 2020
The logs and metrics categories do not exist anymore. In elastic/package-registry#534 the supported categories were updated.

The categories are removed for now to allow the registry to remove the legacy support for these categories. The new releases of these packages must contain the new categories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:beta1 Group issues for ingest management beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants