Skip to content

Commit

Permalink
Define build time dependencies (#181)
Browse files Browse the repository at this point in the history
* Define build time dependencies

* Update changelog

* Address PR comments

* Extract to deps.yaml

* Rename deps.yml to build.yml

* Move build.yml under _dev/build

* Replace array with obj

* Fix
  • Loading branch information
mtojek authored Jun 14, 2021
1 parent 96d8ae4 commit 674263f
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 2 deletions.
2 changes: 1 addition & 1 deletion code/go/internal/spec/statik.go

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions test/packages/good/_dev/build/build.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dependencies:
ecs:
reference: git@7a11f3e1f7d8f05e8f06623fd98254b8cb34c441
26 changes: 26 additions & 0 deletions versions/1/_dev/build/build.spec.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
##
## Describes the specification for the package's main manifest.yml file
##
spec:
# Everything under here follows JSON schema (https://json-schema.org/), written as YAML for readability
type: object
additionalProperties: false
properties:
dependencies:
type: object
description: Package dependencies
additionalProperties: false
properties:
ecs:
description: ECS dependency
type: object
additionalProperties: false
properties:
reference:
type: string
description: Source reference
pattern: 'git@[a-z0-9]{40}'
required:
- reference
required:
- dependencies
5 changes: 5 additions & 0 deletions versions/1/_dev/build/spec.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
spec:
additionalContents: false
contents:
- description: Package build manifest
type: file
contentMediaType: "application/x-yaml"
name: "build.yml"
$ref: "./build.spec.yml"
- description: Folder containing resources related to docs.
type: folder
name: docs
Expand Down
5 changes: 4 additions & 1 deletion versions/1/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,4 +132,7 @@
link: https://github.com/elastic/package-spec/pull/183
- description: Introduce "reference" property for fields
type: enhancement
link: https://github.com/elastic/package-spec/pull/179
link: https://github.com/elastic/package-spec/pull/179
- description: Define build-time dependencies
type: enhancement
link: https://github.com/elastic/package-spec/pull/181

0 comments on commit 674263f

Please sign in to comment.