-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define build time dependencies #181
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c93c184
Define build time dependencies
97435a3
Update changelog
a8915b1
Address PR comments
mtojek 10552d7
Merge branch 'master' into 179-build-dependencies
ef12409
Extract to deps.yaml
c5c33aa
Rename deps.yml to build.yml
7ccc2aa
Move build.yml under _dev/build
57e9fba
Merge branch 'master' into 179-build-dependencies
b532033
Replace array with obj
ec81ed5
Fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
build: | ||
- name: ecs | ||
version: "1.9" | ||
reference: git@7a11f3e1f7d8f05e8f06623fd98254b8cb34c441 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
## | ||
## Describes the specification for the package's main manifest.yml file | ||
## | ||
spec: | ||
# Everything under here follows JSON schema (https://json-schema.org/), written as YAML for readability | ||
type: object | ||
additionalProperties: false | ||
properties: | ||
build: | ||
type: array | ||
description: Build-time dependencies | ||
items: | ||
type: object | ||
additionalProperties: false | ||
properties: | ||
name: | ||
type: string | ||
description: Name of the dependency | ||
enum: | ||
- ecs | ||
version: | ||
type: string | ||
description: Version of the dependency | ||
reference: | ||
type: string | ||
description: Source reference | ||
pattern: 'git@[a-z0-9]{40}' | ||
required: | ||
- name | ||
- reference | ||
required: | ||
- build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
build
redundant now here? What other dependencies can be in this file? If at some moment there are runtime dependencies they will need to be in the manifest, or somewhere downloaded by Kibana.Or perhaps this file can be called
build.yml
in case we need more things in the future only in build time. And this key could be calleddependencies
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with
build.yml
too, although this may suggest to introduce more side features into it :)We have also
_dev
directory, maybe this one is a better fit? For example:_dev/build/deps.yml
. WDYT? Currently we're using the_dev/build/docs
to render README files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the PR to use
build.yml
in the package root directory.